Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The same Webhook events sometimes not getting forwarded to smee proxy #995

Closed
getshravan opened this issue Aug 27, 2019 · 8 comments
Closed
Labels

Comments

@getshravan
Copy link

Bug Report

Current Behavior
The webhook events are not getting sent to smee proxy. I could see the events under Recent Deliveries, but the same payload is not getting sent to smee.io eventually to my probot app when I redeliver

  // Your code here
export = (app: Application) => {
  const exec = require('child_process').exec;
  app.on(['pull_request','pull_request_review','push', 'issue_comment'], async (context) => {

    let prNumber = 0;
    let commentId = 0;
    if(context.event == 'issue_comment' && context.payload.action.trim() == "created") {
      prNumber = context.payload.issue.number;
      commentId = context.payload.comment.id;
    } else {
      prNumber = context.payload.pull_request.number;
    }
    console.log("received GitHub event for pr number:%s, Action:%s, CommentId:%s", prNumber, context.payload.action, commentId);
    exec('ruby  ../pr-scripts/lib/driver.rb -n '+prNumber+' -c '+commentId+' -a '+context.payload.action, function(error: any,stdout: any,stderr: any){
      console.log('stdout: ' + stdout);
      console.log('stderr: ' + stderr);
      console.log('error: ' + error);
    })
  })
}

Expected behavior/code
A clear and concise description of what you expected to happen (or code).

Environment

  • Probot version(s): [e.g. v7.2.0]
  • Node/npm version: [e.g. Node 12.6.0/npm 6.10.3]
  • OS: [e.g. OSX 10.14.6]

Possible Solution

Additional context/Screenshots
This is the smee.io url https://smee.io/2UX9PyyDDg906Jd. The same application use to work before. Sometimes the payload for some event types gets sent to the probot app, if I try to deliver them again, it won't be sent.

@welcome
Copy link

welcome bot commented Aug 27, 2019

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@issue-label-bot issue-label-bot bot added the bug label Aug 27, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug 🐞 to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@gr2m
Copy link
Contributor

gr2m commented Aug 27, 2019

smee.io is currently experiencing problems, it's not a problem with probot. We hope we can resolve the problems soon. For the time being you can deploy your own smee instance

@getshravan
Copy link
Author

getshravan commented Aug 28, 2019

@gr2m Thanks for the quick response. Are there any instructions on how to setup our own instance of smee server? I didn't find any instructions here

@gr2m
Copy link
Contributor

gr2m commented Aug 28, 2019

hm I thought we would. As far as I know it’s a simple, stateless Node server so should be easy to deploy to eg heroku or now.

I also think that smee.io is back :)

@getshravan
Copy link
Author

getshravan commented Aug 29, 2019

@gr2m I am using our companies enterprise GitHub, considering security, Is there a way I can directly configure my IP (server IP where probot is running), instead of using web proxies like smee, Glitch, now etc. There is also an unanswered question in stack overflow on the same topic. It would be really of great help if it get answered. Thanks

@gr2m
Copy link
Contributor

gr2m commented Aug 30, 2019

I think that this would be a better question for support@github.com, I don't really know much about GitHub Enterprise I'm afraid

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 29, 2019
@stale stale bot closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants