Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work on PRs #38

Closed
derberg opened this issue Sep 13, 2018 · 5 comments
Closed

doesn't work on PRs #38

derberg opened this issue Sep 13, 2018 · 5 comments
Labels

Comments

@derberg
Copy link

derberg commented Sep 13, 2018

Hey, awesome bot but looks like it works on issues only

please take a look:

@stale
Copy link

stale bot commented Dec 12, 2018

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Dec 12, 2018
@stale stale bot closed this as completed Jan 19, 2019
@iamareebjamal
Copy link

This should be reopened as it does not work on PRs

@flipace
Copy link

flipace commented Feb 16, 2019

I checked this with a fork, and i believe that the permissions for this app must be changed.
When configured correctly (= R/W access for PRs) it properly reacts to the sent comments.

So, apparently this published app is only configured to work with issues, but not prs (you can easily see this on the configuration screen of it as well).

Until this is fixed here, i published the same app with proper permissions: https://github.com/apps/reminders-prs

GitHub
GitHub is where people build software. More than 31 million people use GitHub to discover, fork, and contribute to over 100 million projects.

@gillesdemey
Copy link

I also believe this should be reopened, as the original issue is not solved :)

@nomeata
Copy link

nomeata commented Jul 22, 2019

Thanks @flipace, using your fork now :-)

Hope this can be fixed with the official one at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants