Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Guard against malformed configuration #62

Closed
bkeepers opened this issue Sep 26, 2017 · 2 comments
Closed

Guard against malformed configuration #62

bkeepers opened this issue Sep 26, 2017 · 2 comments
Labels

Comments

@bkeepers
Copy link
Contributor

https://sentry.io/probot/stale/issues/307099740/ is an error caused by an installation that has an array value for staleLabel, which is not expected. In this case, passing that parameter on to the GitHub API doesn't cause any harm, but there could be other instances where it does.

We should do an audit of all config values to ensure they're properly checked before being used in an API request.

Error: {"message":"Invalid request.\n\nFor 'properties/name', [\"wontfix\", \"duplicate\", \"invalid\"] is not a string.","documentation_url":"https://developer.github.com/v3/issues/labels/#create-a-label"}
@bkeepers
Copy link
Contributor Author

bkeepers commented Jan 2, 2018

There are a lot of errors caused by mis-configuration.

The app should validate the type of every field and fail on invalid configuration.

@stale
Copy link

stale bot commented Apr 5, 2018

Is this still relevant? If so, please comment with any updates or addition details.

@stale stale bot added the wontfix label Apr 5, 2018
@stale stale bot closed this as completed Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant