Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paint/render edge arrow in svg export #54

Open
tbouffard opened this issue Jul 16, 2020 · 1 comment
Open

Paint/render edge arrow in svg export #54

tbouffard opened this issue Jul 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tbouffard
Copy link
Member

#52 introduced edge display in the svg export, but there is currently no arrow.
We probably will need the edge direction to know how to paint the arrow
@tbouffard tbouffard added the enhancement New feature or request label Jul 16, 2020
@tbouffard tbouffard changed the title Add edge arrow in svg export Paint/render edge arrow in svg export Jul 16, 2020
@tbouffard tbouffard mentioned this issue Jun 7, 2021
Merged
@tbouffard
Copy link
Member Author

tbouffard commented Jun 7, 2021 •
edited

#82 marks the edge target point with a circle. This is a 1st implementation that let identify the direction of the edge.
Rendering arrow is more complex as it requires to know the last segment orientation. This information is currently not available in the code that manage the SVG export.
We only have the point coordinates, the orientation computed before is not passed along with the point.

I am not sure we really need the arrow here. The circles provide the main info: the edge direction.
So IMHO, circles are enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbouffard