Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Don't trigger panning with the right mouse button #768

Closed
tbouffard opened this issue Oct 14, 2020 · 2 comments · Fixed by #1003
Closed

[FEAT] Don't trigger panning with the right mouse button #768

tbouffard opened this issue Oct 14, 2020 · 2 comments · Fixed by #1003
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request mxgraph integration Something involving mxGraph (be aware of EOL)
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Oct 14, 2020

Is your feature request related to a problem? Please describe.
The initial implementation also allows to trigger the panning by clicking the right button (supported by default by mxGraph).
This is an unusual way for panning and this currently displays the context menu which is a strange behaviour.

Example when using the A.2.0 miwg-test-suite file on Firefox 81.0 (French Language)

panning_right_button_trigger

Describe the solution you'd like
Only trigger the panning with the mouse left button

Additional context
Implementing this will avoid any side effect in the future if want to assign special action to the right button (custom context menu for intance)

@tbouffard tbouffard added the enhancement New feature or request label Oct 14, 2020
@tbouffard tbouffard changed the title [FEAT] [FEAT] Don't trigger the panning with the right mouse button Oct 14, 2020
@tbouffard
Copy link
Member Author

I have tried disabling the right button support with the following but I have seen no effect (mxgraph@4.1.0)

this.graph.panningHandler.usePopupTrigger = false; // only use the left button to trigger panning

@tbouffard tbouffard changed the title [FEAT] Don't trigger the panning with the right mouse button [FEAT] Don't trigger panning with the right mouse button Oct 14, 2020
@tbouffard tbouffard added the BPMN diagram usability Something about the way we can interact with BPMN diagrams label Oct 30, 2020
@tbouffard tbouffard added the mxgraph integration Something involving mxGraph (be aware of EOL) label Dec 15, 2020
@tbouffard tbouffard added this to To do in Day to Day Board via automation Jan 5, 2021
@tbouffard tbouffard moved this from To do to In Review in Day to Day Board Jan 5, 2021
@tbouffard
Copy link
Member Author

I have tried disabling the right button support with the following but I have seen no effect (mxgraph@4.1.0)

this.graph.panningHandler.usePopupTrigger = false; // only use the left button to trigger panning

This parameter was ignored as we also set ignoreCell to true. See #1003

Day to Day Board automation moved this from In Review to Done Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request mxgraph integration Something involving mxGraph (be aware of EOL)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant