Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU usage reduction suggestion for the DnsCache View Plugin #69

Open
DavidXanatos opened this issue Aug 21, 2019 · 0 comments
Open

CPU usage reduction suggestion for the DnsCache View Plugin #69

DavidXanatos opened this issue Aug 21, 2019 · 0 comments

Comments

@DavidXanatos
Copy link
Contributor

In the DnsCache View Plugin in the main.cpp function TraverseDnsCacheTable,
for every entry obtained with DnsGetCacheDataTable_I
the function loops through all types deemed interesting defined in the typeList array,
this seams very inefficient as according to S2017 cpu profiler DnsQuery causes quite a significant CPU load.
instead of looping through all types for each entry, why not just check tablePtr->Type, if its one of the interesting types and than call only DnsQuery(tablePtr->Name, tablePtr->Type, ...)
That would save a lot of CPU cycles.

@dmex dmex transferred this issue from winsiderss/systeminformer Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant