[FIXED ]Crash v3.0.8788.4261 Git-75b931fc or never if try open Hacker menu or try open context menu use RMsClick or KBD Apps button in to tray miniWindow

[VictorVG]

Crash v3.0.8788.4261 Git-75b931fc ( also v3.0.8789.4262 Git-04479f7d and v3.0.8790.4263 Git-8afff310) if try open Hacker menu

OS Win7 SP1 x64.

If i try open Hacker menu then v3.0.8789.4262 Git-04479f7d (also v3.0.8790.4263 Git-8afff310) is crashed and debugger show messages "Unhandled exception at address 0x00000000xxxx (ntdll.dll) in ProcessHacker: .exe 0xC0000225: Object not found." for .\ProcessHacker\settings.c string 373 as crashed location.

for v3.0.8789.4262 Git-04479f7d:

for v3.0.8790.4263 Git-8afff310:

My crash dumps needed?

P.S.

Possible crashed in to \ProcessHacker\mainwnd.c :: 1854 :

    if (PhPluginsEnabled)
    {
        PH_PLUGIN_MENU_INFORMATION pluginMenuInfo;

        PhPluginInitializeMenuInfo(&pluginMenuInfo, menu, WindowHandle, PH_PLUGIN_MENU_DISALLOW_HOOKS);
        pluginMenuInfo.u.MainMenu.SubMenuIndex = Index;
        PhInvokeCallback(PhGetGeneralCallback(GeneralCallbackMainMenuInitializing), &pluginMenuInfo);
    }

????

[dmex]

Crash v3.0.4261

The latest official build is v3.0.4234... your 4261 build is compiled from sources which are incomplete.

[VictorVG]

Issues is close, but crash exist:

[dmex]

Issues is close, but crash exist

The files have other changes which haven't been completed... It'll get fixed when those other changes are published.

[VictorVG]

Ok! Understood. I'll wait, otherwise I thought I had an accident again - Friday, the 13th - "unlucky day." As Leonid Sobolev wrote in his story "Friday 13":

Leonid Sergeevich Sobolev. The stories of the captain of the 2nd rank V.L.Kirdyagi, heard from him during the "Great Seat"

Thirteenth, Monday

...

So during the war we stood in the Riga Gulf in Rajekyul near
English submarines, and I talked about it with one officer, he and
Laughs: "Strange you people, says Russian! Well, it is clear - the whole world knows,
That thirteenth on Monday in Morse is dangerous. But why not in
Friday? This is just superstition! "I ask:" And Monday, what, not
Superstition? "-" Of course no, "says. - This is the result of long observations. IN
Sunday every decent sailor drunk so that on Monday it
It also drifts and in the brains such a deviation is that it does not distinguish the nose from the feed. AND
World statistics shows that the greatest number of accidents have
on Monday. What is up to the thirteenth number, then again the whole world knows
that in England either one street has no house number thirteen, but there is
Twelight-bis, because thirteen - the number is unhappy. And nobody
The enemy: if with drunk eyes thirteenth, and even on Monday, in the sea
Enjoy, then it smells like an accident, but death. This is all explained! BUT
Your superstitions are just funny. "And this Englishman is right: really,
Monday is a lothe day, and the thirteenth additionally presses the psyche.

....
:)

[VictorVG]

Git [d4be140] 2021-08-14 06:50:12 +1000 dmex : Fix start performance monitor and restart to firmware menus on Win7

try test open Hacker menu, but crash in exception 0x00000225 - Required object not exist

[VictorVG]

v3.0.8798.4271 Git-b6644725 also crashed in to new dynamic Hacker menu code:

For experiment, in order to exclude the possible influence of plugins, I specially minimized the set of files in the test copy to ProcessHacker.exe, ProcessHacker.exe.settings.xml (initial length 0 bytes), ProcessHacker.pdb, ProcessHacker.sig, capslist.txt, etwguids.txt , usernotesdb.xml (initial value is "empty"), but a drop of 100% is reproducible.

Therefore, after looking at the code, I see this option:

if IsOsVersion >= Win8 then call: new_dynamic_menu_code else goto: legacy_menu_code end
: legacy_menu_code
// the same code as before v3.0.8787.4260 Git-26fbe412 inclusive;

and in the new_dynamic_menu_code block, combine all the code that works with dynamic menus, for example, as a separate subroutine, possibly putting it into a separate source file for ease of development.

Now the algorithm, having checked the OS version in one place in others, does not perform this check and always adds items to the Hacker menu indicating non-existent objects, which leads to a failure.

PH_v3.0.8798.4271_Git-b6644725_x64_crash.zip - test copy and crash dump.

[VictorVG]

Also skipik (he use OS Windows 10/11 Latest ) X6415.08.2021 speech me in PM on forum.ru-board.com:

"The pH also drops, and not only calling the main menu, but also if you make a PCM on the tray icon. That is, the pH is minimized and we are trying to call the context menu."

[VictorVG]

Also test - v3.0.8798.4271 Git-b6644725, OS Win7 SP1 x64, Win10 21H1 (test by skipik), PH minimize in to try. Goto mini Window, if I press KBD Apps or use RMsClick in to this window - the have crash this exception code 0x00000225 "Object not found".

Possible this crash have some source like crash if try open Hacker menu.

[VictorVG]

v3.0.8799.4272 Git-31e7947f - the mini tray window worked without errors, but the crash when trying to open the Hacker menu was saved .

[VictorVG]

v3.0.8803.4276 Git-6a26e9ca - issues is closed, but bug is exist - if I try open Hacker menu then crash this exception 0x00000225 Object not found ....

[dmex]

issues is closed, but bug is exist

Debug assertions that were added manually are not bugs. These are features being developed and not complete. I am still working on those menus so they'll keep asserting until they're completed.

I try open Hacker menu then crash this exception 0x00000225 Object not found

You're compiling source code with bleeding edge changes that I haven't had time to complete... These are not crashes, they're debug assertions required for source development.

There haven't been any official releases of the nightly builds or otherwise... If you need a stable version of the source then use revisions with a green tickbox:

If you don't know what assertions are or how to use them then only use revisions with those green ticks otherwise expect problems like assertions and debug statements and whatever.

I'm well aware these menus don't work yet... When those new features are complete the assertions will be removed hopefully within the next week or so.

[VictorVG]

Ok! I wait...

[VictorVG]

Big thanks! This issues fixed in to v3.0.8817.4290 Git e068524.