Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rename PhFreeJsonParser to PhFreeJsonObject in to ./tools/CustomSetupTool/download.c::341 in Git 3e584574e and try fix build error #981

Closed
VictorVG opened this issue Sep 1, 2021 · 0 comments

Comments

@VictorVG
Copy link

VictorVG commented Sep 1, 2021

Missing rename PhFreeJsonParser to PhFreeJsonObject in to ./tools/CustomSetupTool/download.c::341 in Git 3e58457 and build failure:

Windows: Windows NT 6.1.7601.0
WindowsSdk: 20348 (16.11.31603.221)
VisualStudio: VisualStudio/16.11.2 + 31624.102

Building ... 3.0.8858.4331 (3e58457) [Master]

[03:20] Building Build-Setup.exe ... [Error] (1) .\Tools\CustomSetuptool\Download.c (341.25): Warning C4013: PhFreeJSonParser: no definition; It is assumed to "extern" with the return type "int" [.\Tools\CustomSetuptool\CustomSetuptool.vcxproj]
Download.Obj: Error LNK2001: unresolved external symbol _phfreejsonparser @4. [.\Tools\CustomSetuptool\CustomsetUpTool.vcxproj]
.\Tools\Release32\CustomSetuptool.exe: Fatal Error LNK1120: unresolved external elements: 1 [.\Tools\CustomSetuptool\CustomSetuptool.vcxProj]

after manual rename ./tools/CustomSetupTool/download.c::341 PhFreeJsonParser to PhFreeJsonObject build is success:

Windows: Windows NT 6.1.7601.0
WindowsSDK: 20348 (16.11.31603.221)
VisualStudio: VisualStudio/16.11.2+31624.102

Building... 3.0.8859.4332 (7b17f25) [master]

[00:01] Building ProcessHacker (x32)... 
[01:11] Building ProcessHacker (x64)...
[02:23] Building Plugins (x32)...
[02:56] Building Plugins (x64)...
[03:32] Building build-bin.zip... 6Mb
[03:33] Building build-setup.exe... 9Mb
[03:42] Building build-pdb.zip... 46Mb
[03:49] Building build-sdk.zip... 9Mb
[03:50] Building release checksums...

Build Time: 3 minute(s), 51 second(s)

, but insofar as I don't use this installer (I use custom Inno Setup installer) then not tested this fix.

@dmex dmex closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants