Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on commit 921dbc93f029a9 #12

Closed
VictorVG opened this issue Feb 24, 2016 · 1 comment
Closed

Build failure on commit 921dbc93f029a9 #12

VictorVG opened this issue Feb 24, 2016 · 1 comment

Comments

@VictorVG
Copy link

Problem file is phlib/lsa.c strings 148 and 180 found in commit 921dbc9:

strings 148:

-    PhStringRefToUnicodeString(PrivilegeName, &privilegeName);  /* old version this string - no problem */
+    if (!PhStringRefToUnicodeString(PrivilegeName, &privilegeName)) /* added if ... and have problem */
+        return STATUS_NAME_TOO_LONG;

and VS2015 write to log:

1> lsa.c (149): error C2220: warning treated as error - "object" file is created
1> lsa.c (149): warning C4305: return: truncated from "NTSTATUS" to "BOOLEAN"
1> lsa.c (181): warning C4305: return: truncated from "NTSTATUS" to "BOOLEAN"
2> .. \ phlib\lsa.c (149): error C2220: warning treated as error - "object" file is created
2> .. \ phlib\lsa.c (149): warning C4305: return: truncated from "NTSTATUS" to "BOOLEAN"
2> .. \ phlib\lsa.c (181): warning C4305: return: truncated from "NTSTATUS" to "BOOLEAN"

========== Build: successfully: 0, with errors: 4, without changes: 0, conceded: 1 ==========

P.S.

Lines in phlib/lsa.c 148 and 180 caused the build fails before the compiler began processing phlib/native.c where there is a similar syntax in the line 6002, and therefore it is in theory should lead to the generation error C2220 and warning C4305 with followed by the failure of assembly...

@wj32 wj32 closed this as completed Feb 24, 2016
@VictorVG
Copy link
Author

Big thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants