Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error lines not displayed on windows #25

Open
Efratror opened this issue Apr 1, 2022 · 0 comments · May be fixed by #26
Open

[BUG] Error lines not displayed on windows #25

Efratror opened this issue Apr 1, 2022 · 0 comments · May be fixed by #26

Comments

@Efratror
Copy link

Efratror commented Apr 1, 2022

bug:

Error lines are not displayed on Windows.

println("x") (without semicolon) should result in an error but non is shown

possible solution(s):

  • Windows paths include a colon after the drive letter. In Diagnostics.ts the split position is hard-coded. Checking the OS-type and then setting the split position accordingly should solve the issue.
  • When checking if the line includes the path due to windows using backslashes instead of forward slashes the check will always be false. Also make the path to check OS-dependent in the caller (parser.ts)
@Efratror Efratror linked a pull request Apr 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant