Feature/multi tab support #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A sketch is the contents of all files in the directory. A transformation map is used to switch between line numbers in the java file and the .pde file (tab)
The definition, diagnostic and reference capabilities of the server need to change to accommodate for multi-tab support. The line number of the .pde file(tab) needs to be retrieved from the sketch in order to display relevant information correctly
Bigcount wasn't incremented after the first run but became 1 again. This resulted in an error on a second tab not mapping correctly to the original .pde file and line number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for sketches with multiple files/tabs.
Description of the changes
All the .pde files in a workspace are keyed by there filename with there contents as value in to a contents map. When a file changes, is added or removed the map is updated. When preprocessing starts each line of the contents map is added to a bigcode block. Each line number of the file/tab is keyed to the line number of the big code block. The big code block is then further preprocessed.
When a server request (definition, diagnostics or reference) is passed by the client. The line number of the big code is converted to the line number of the file/tab it belongs to.
Closes #28