Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to run checks #91

Closed
Qianqianye opened this issue Mar 28, 2024 · 6 comments · Fixed by #114
Closed

Setting to run checks #91

Qianqianye opened this issue Mar 28, 2024 · 6 comments · Fixed by #114

Comments

@Qianqianye
Copy link
Collaborator

Hi @stalgiag @outofambit,

I can't merge the translation PRs because most of the latest PRs won't run the check, like #78. Is there a setting you can update to allow the PRs from other contributors to run checks? Or can you update my permission to run the checks? Thanks!

CC @limzykenneth @davepagurek

@stalgiag
Copy link
Collaborator

I made sure that all of you are admins. Not sure why those tests still are not running. The settings allow for workflows to happen for PRs from new contributors. Since they are just translations, you can bypass the status check if needed for unblocking

@limzykenneth
Copy link
Member

Ideally it would be good to have the tests run and passed as there could be formatting issues. I'm also not able to merge it bypassing the checks and the only option is "Enable auto-merge", there's also no option currently to start the workflow run though, not sure why as it is not indicating that it requires permission or something.

@stalgiag
Copy link
Collaborator

stalgiag commented Mar 28, 2024

I agree that confirming that the tests pass would be ideal. That said, you should be able to merge with bypassed status checks by first clicking the checkbox. You have the same repo permissions as me and this is what I see:

Screenshot 2024-03-28 at 2 31 15 PM

If you click "Merge without waiting for requirements to be met" that should give you the option to merge.

I think this issue might be similar to this where something about an Action triggering another Action caused GH to hang up. The accepted answers on that page seem to be closing and reopening the PRs or pushing empty commits.

@davepagurek
Copy link
Collaborator

Just a heads up, I had to fix some build errors (#109) from indentation and little minor things that are hard to check by skimming a PR manually.

@outofambit
Copy link
Collaborator

hi all! i realized the issue was that our CI workflows didn't support PRs from forks. i fixed this in #114 and updated all the open PRs to have this change. if anyone opens a PR from a fork and has this issue, updating the PR from main should get it unstuck. thanks!

@davepagurek
Copy link
Collaborator

awesome, thanks @outofambit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants