Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p5 touch event blocks normal touch behavior #1887

Closed
milkyklim opened this issue Apr 11, 2017 · 3 comments
Closed

p5 touch event blocks normal touch behavior #1887

milkyklim opened this issue Apr 11, 2017 · 3 comments
Labels

Comments

@milkyklim
Copy link

I have a sketch on my webpage.

Sketch code.

Expected behavior: when mouse is clicked or touch is down invert sketch colors.

Desktop version is fine.

Mobile version is not working properly. When I touch the screen the color changes but I can't click any of the objects on the page (try share buttons, previous post or leave comments).

I think this is a bug because I don't use anything like function touchStarted(){ return false; } to prevent normal touch workflow.

Tested the code on iPhone 5, Safari.

@b2renger
Copy link
Member

I have the same problem here : https://b2renger.github.io/p5js_harmony-directed-layout/
I'm using p5js with quicksettings

0.58 : I cannot modify quicksettings paremeters on a mobile browser.
0.57 : does work with quicksettings but has still the double firing bug on mobile

There have been some related changes here that have proably broken things down cc52045
but I don't I get it

@b2renger
Copy link
Member

@milkyklim

So after investigations, the commit I mentionned earlier is actually the fix for our bug.
It turns out that this commit is not in 0.58 and will be in the next release.

I checked out the master branch built the lib according to these instructions https://github.com/processing/p5.js/wiki/Development

and replaced the p5.js file, it works but I get back the double firing bug on mobile.
While waiting for 0.59 you can either get back to 0.57 or get the 0.58-1 I built (here : https://github.com/b2renger/p5js_harmony-directed-layout/blob/master/libraries/p5-0.58.1.js)

this probably shoud be kept open until a new version si rolled out.

@lmccart lmccart added the Mobile label Apr 15, 2017
@milkyklim
Copy link
Author

The problem I had is solved in 0.5.9. We can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants