Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that p5.Framebuffer settings work in all environments #6083

Closed
1 of 17 tasks
davepagurek opened this issue Mar 21, 2023 · 3 comments
Closed
1 of 17 tasks

Verify that p5.Framebuffer settings work in all environments #6083

davepagurek opened this issue Mar 21, 2023 · 3 comments

Comments

@davepagurek
Copy link
Contributor

Increasing Access

Once we add support for framebuffers in #6072, although it has been heavily manually tested by the authors and also unit tested, more manual testing on more environments will help make sure it works smoothly for everyone. Small inconsistencies in WebGL drivers on different browsers and OSes have come up in the past, so it would be great to catch them early.

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build Process
  • Unit Testing
  • Internalization
  • Friendly Errors
  • Other (specify if possible)

Feature enhancement details

There are a few manual test examples in /test/manual-test-examples/webgl/framebuffer. These have been tested by me already in Chrome and Firefox on an M1 Macbook Pro, but it would be great if these could also be tested:

  • On older Macs without Apple silicon (possibly with older Safari too)
  • On Windows on various browsers
@wong-justin
Copy link
Contributor

I viewed the manual test examples on Windows 10, with Firefox/Chrome/Edge versions 114.0. Everything seemed to work fine, no fps problems or unexpected behavior as far as I could tell.

@davepagurek
Copy link
Contributor Author

Thanks @wong-justin! I have access to old Safari I can test on, so I'll double check there too, and close this issue if everything looks good.

@davepagurek
Copy link
Contributor Author

Everything runs without crashing on Safari 12 (with no WebGL2 support, so everything falls back to WebGL1), so I'm going to call this issue done 🙂

@davepagurek davepagurek moved this from Minor Enhancement to DONE! 🎉 in p5.js WebGL Projects Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: DONE! 🎉
p5.js WebGL Projects
  
DONE! 🎉
Development

No branches or pull requests

2 participants