Safari cannot find requestAnimationFrame

[codeanticode]

I tried to run pjs script using different versions of Safari, including the latest one included in 10.8.5, and get the following error:

pjs.js:1605 ReferenceError: Can't find variable: requestAnimationFrame

which corresponds to the following code in pjs.js:

if (pLoop) {
  setTimeout(function() {
    requestAnimationFrame(pDraw);
  }, 1000 / frameRate);
}

Part of https://github.com/lmccart/processing-js/issues/20

[taseenb]

In the last Safari it still requires the "webkit" prefix. You can use something like this to make sure it works (almost) everywhere:

// requestAnim shim layer by Paul Irish
window.requestAnimFrame = (function(){
  return  window.requestAnimationFrame       || 
          window.webkitRequestAnimationFrame || 
          window.mozRequestAnimationFrame    || 
          window.oRequestAnimationFrame      || 
          window.msRequestAnimationFrame     || 
          function(/* function */ callback, /* DOMElement */ element){
              window.setTimeout(callback, 1000 / 60);
          };
})();

Browser support: http://caniuse.com/requestanimationframe

[lmccart]

thanks @taseenb! @codeanticode do you want to try this in your version of safari and close if it works? we haven't really been testing in anything other than chrome yet, but this is a great start.

[codeanticode]

this pr should fix it https://github.com/lmccart/processing-js/pull/74, I tested on safari 6.0.5 only.

[lmccart]

oh wow I didn't hook that last attempt of mine in correctly at all, must be very tired, sorry about that. thanks for the fix.