LSP feature/declaration support #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We'll give it a shot for 4.2.1. Main thing with the code would be following the style guidelines, but the rest looks ok as far as how it integrates with the rest of the source. I don't have time this morning to dig through the code in detail but hopefully having it in use will shake things out a bit. Great to have more features coming to the LSP implementation! |
benfry
added a commit
that referenced
this pull request
Feb 27, 2023
|
Thanks for the quick review. I've seen the style guide and tried to follow them as closely as possible. Clearly i've misunderstood some parts or wasn't consistent enough. Can you please clarify? @benfry |
Efratror
added a commit
to Efratror/processing4
that referenced
this pull request
Mar 19, 2023
As noted by mr. Fry in PR benfry#678 and issue benfry#684
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added declaration support by rewriting a part of InspectMode.java and adding this capability to the server.
Please give your honest code-review. As i'm not as experienced in java it was my first time using CompletableFutures and Optionals. There are probably faster ways but i've written them out allot to understand them.
Should resolve #676