Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Flows in Crown #1319

Closed
velkymx opened this issue Jan 5, 2021 · 1 comment · Fixed by #1328
Closed

Merge Flows in Crown #1319

velkymx opened this issue Jan 5, 2021 · 1 comment · Fixed by #1328
Labels
enhancement New feature or request

Comments

@velkymx
Copy link
Contributor

velkymx commented Jan 5, 2021

When choosing a flow in the CROWN I'd like there to be only a single crown icon. Once the link is connected to an element, and depending on the element type, the link should automatically change to the correct link type (solid, dashed or dotted)

image

@velkymx velkymx added the enhancement New feature or request label Jan 5, 2021
@velkymx velkymx added this to To do in Winter Sprint via automation Jan 5, 2021
@vehikl-jacare vehikl-jacare moved this from To do to In progress in Winter Sprint Jan 6, 2021
@vehikl-jacare vehikl-jacare moved this from In progress to Ready in Winter Sprint Jan 7, 2021
@vehikl-jacare
Copy link
Contributor

We've been doing some exploratory work in 1319-merge-flows but are parking it for now to look at higher-priority tasks.

Notes for when we resume - the basic idea is to:

  • add a new generic placeholder element ('processmaker-modeler-generic-flow')
  • draw the interim lines using the orthogonal router
  • extract validity logic from sequenceFlow, messageFlow, and dataFlow to modules
  • use the extracted validity logic inside the generic flow to determine if the source and target nodes can form a valid flow, and if so, of what type
  • replace the placeholder element with a valid flow element of the type just determined.

@vehikl-jacare vehikl-jacare moved this from Ready to start to In progress in Winter Sprint Jan 13, 2021
@johnblackspear johnblackspear moved this from In progress to In Review in Winter Sprint Jan 16, 2021
Winter Sprint automation moved this from In Review to Done Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants