filter_packet hook

[skhaz]

What version of ejabberd are you using?

lastest (from the master branch)

What operating system (version) are you using?

macOS 10.12.6

How did you install ejabberd (source, package, distribution)?

source

What did not work as expected? Are there error messages in the log? What
was the unexpected behavior? What was the expected result?

I am wondering if the filter_packet hook signature was changed, I was following this article to create a simple hook in Elixir, but the code seems that doesn't work anymore.

defmodule PacketFilter do
  import Ejabberd.Logger
  @behaviour :gen_mod
  def start(_host, _opts) do
    info('Starting ejabberd module Filter Packet Demo')
    Ejabberd.Hooks.add(:filter_packet, :global, __ENV__.module, :on_filter_packet, 50)
    :ok
  end

  def stop(_host) do
    info('Stopping ejabberd module Filter Packet Demo')
    Ejabberd.Hooks.delete(:filter_packet, :global, __ENV__.module, :on_filter_packet, 50)
    :ok
  end

  def on_filter_packet({from, to, xml={:xmlel, "message", attributes, children}} = packet) do
     # This hook is never called.
    # What I want only packets of type `message` here.

    info("on_filter_packet [1] #{inspect packet}")
    packet
  end

  def on_filter_packet(packet) do
    # Always called, without this hook, the ejabberd throws a lot of erros.
    info("on_filter_packet [2] #{inspect packet}")
    packet
  end

end

[zinid]

Well, yes, and the change is almost one year old.

[badlop]

Right. Instead of: {From, To, Packet}, now the argument is simply: Packet

This change was introduced around ejabberd 17.03: 8b2d308#diff-b81e1bd5c308d13a2065da751c70b882L258

[skhaz]

Thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.