Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show info message in console window when already in encrypted session #1093

Closed
kaffeekanne opened this issue May 9, 2019 · 3 comments
Closed
Assignees
Milestone

Comments

@kaffeekanne
Copy link
Contributor

When already in an OMEMO session with a contact issueing /omemo start <contact> from a muc/chat window throws ! You are already in an OMEMO session. as informational message in that starting muc/chat window.

The message is correct since the session was started, i would expect that it in the console window or the chat window of the contact i falsly tried to start the session with. Unfortunately i have no idea hot OTR or PGP handle that situation.

@kaffeekanne kaffeekanne changed the title Show infor message in console window when sstarted OMEMO session Show info message in console window when already in OMEMO session May 9, 2019
@kaffeekanne kaffeekanne changed the title Show info message in console window when already in OMEMO session Show info message in console window when already in encrypted session May 22, 2019
@kaffeekanne
Copy link
Contributor Author

Looking into the code,i see this applies to all info messages about started encrypted sessions, be it OTR, GPG or OMEMO. I think that information does not belong in the chat window where i try to start the OMEMO session, since i am moved to the newly created window and will not see that notice. It either should be shown in the newly created window or in the console window.

@jubalh
Copy link
Member

jubalh commented Jun 7, 2019

I guess the right behaviour would be to write it in the chat window of that contact. Also console?

@jubalh jubalh added this to the 0.7.0 milestone Jun 7, 2019
@jubalh jubalh self-assigned this Jun 7, 2019
@kaffeekanne
Copy link
Contributor Author

Chat window is probably enough. If also console, then the contact needs to be mentioned so you know where the informational message belongs to.

@jubalh jubalh closed this as completed in 2eb2bf3 Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants