Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme setting statusbar text gets misinterpreted #1095

Closed
kaffeekanne opened this issue May 13, 2019 · 7 comments
Closed

Theme setting statusbar text gets misinterpreted #1095

kaffeekanne opened this issue May 13, 2019 · 7 comments
Milestone

Comments

@kaffeekanne
Copy link
Contributor

Because of #1077 i was testing some theme stuff and found the following behavior when trying to set the color for inactive (default cyan) windows in statusbar. Everything gets bold, screenshot does not really tell that, nevertheless:

themes_wrong_color

Reproduce by placing a minimal theme file in ~/.config/profanity/themes/ containing:

[colours]
statusbar.text=bright_red

What i expected was to set the text color of my jid only. What i was searching for, was a way to set the color of inactive windows. Also setting a bracket/char apart from default - for active windows would be nice.

@jubalh jubalh added this to the 0.8.0 milestone Jun 5, 2019
@jubalh
Copy link
Member

jubalh commented Jun 7, 2019

Sorry. I read it three times, but I dont get what is happening :S

@wstrm
Copy link
Contributor

wstrm commented Jun 9, 2019

I'm not sure it's the same issue, but I get that the color from the previous field "leaks" over to the next field, e.g. if the first field is red and the second white (no color), the second fields becomes red.

I suppose this is due to a missing \e[0m?

@jubalh
Copy link
Member

jubalh commented Jun 9, 2019

I suppose this is due to a missing \e[0m?

I suppose this has to be somewhere. I remember another issue about something similar, but can't find it right now.

@jubalh
Copy link
Member

jubalh commented Jun 11, 2019

When/where exactly does it happen for you guys?

@jubalh
Copy link
Member

jubalh commented Sep 29, 2019

@kaffeekanne @optmzr ping :)

@jubalh
Copy link
Member

jubalh commented Oct 23, 2019

statusbar.text=bright_red

bright is not a valid value.

@jubalh
Copy link
Member

jubalh commented Oct 23, 2019

when trying to set the color for inactive (default cyan) windows in statusbar.

statusbar.active= sets the color of the not currently selected tab.
statusbar.current= sets the color of the currently selected tab.
statusbar.text= sets the color of the general text in the statusbar (to my knowledge this is user/barejid/fulljid).

Since there was no response, and I think it was just using the theme attrs wrongly I'll close this.

@jubalh jubalh closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants