Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occupants and roster char are not saved #1244

Closed
jubalh opened this issue Dec 20, 2019 · 2 comments
Closed

Occupants and roster char are not saved #1244

jubalh opened this issue Dec 20, 2019 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@jubalh
Copy link
Member

@jubalh jubalh commented Dec 20, 2019

/occupants char @ /roster contact char @ /roster room char # /save and restart.

The settings are not persistent.

@jubalh jubalh added the bug label Dec 20, 2019
@jubalh jubalh added this to the 0.8.0 milestone Dec 20, 2019
@jubalh jubalh self-assigned this Dec 20, 2019
@jubalh

This comment has been minimized.

Copy link
Member Author

@jubalh jubalh commented Dec 20, 2019

Seems to be due to #1077.

@jubalh jubalh closed this in 92c8366 Dec 20, 2019
@jubalh

This comment has been minimized.

Copy link
Member Author

@jubalh jubalh commented Dec 20, 2019

So far /occupants char *, /roster contact char *, /roster room char #,
/roster header char -, /occupants header char - was saved and
loaded from the preferences.

But was overwritten when the theme was loaded. If the theme didn't set
these values the value was just cleared. Despite that it might have been
set in the users preferences.

Funny enough the themes don't operate generally like this.
For example otr.char is not cleared.

This is again due to our borked theme/prefs concept
(#1077).

For now let's just use the one set from the preferences if it's set. The
theme will however overwrite it if it is set there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.