Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with /color on, background of nicks is always black #1255

Closed
misaflo opened this issue Jan 17, 2020 · 2 comments
Closed

with /color on, background of nicks is always black #1255

misaflo opened this issue Jan 17, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@misaflo
Copy link
Contributor

misaflo commented Jan 17, 2020

Expected Behavior

When we use consistent color generation for nicks (/color on) and a theme with non-black background (for example: bkgnd=Grey11), the background of nicknames should be the same color as bkgnd.

Current Behavior

The background color of nicknames is always black.

Possible Solution

May be use an option to customize nickname background color?

As we don't choose colors of nicks, it may be not be very readable with non-black background?

Steps to Reproduce (for bugs)

/color on
/theme load bios

Environment

profanity -v
Profanity, version 0.7.1dev.makepkg.44204635
Copyright (C) 2012 - 2019 James Booth <boothj5web@gmail.com>.
Copyright (C) 2019 - 2020 Michael Vetter <jubalh@iodoru.org>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libmesode
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.13.1)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.8.1)
GTK icons: Enabled
@jubalh jubalh self-assigned this Jan 18, 2020
@jubalh jubalh added the bug label Jan 18, 2020
@jubalh jubalh added this to the 0.8.0 milestone Jan 18, 2020
@jubalh jubalh closed this as completed in 802df37 Jan 22, 2020
@jubalh
Copy link
Member

jubalh commented Jan 22, 2020

For now we just use the default background color.

@misaflo
Copy link
Contributor Author

misaflo commented Jan 22, 2020

It works! Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants