-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main.text.me = main.text.them? #1441
Comments
My problem was that index 687af3b2..663b49b5 100644
--- a/src/ui/window.c
+++ b/src/ui/window.c
@@ -1215,7 +1215,7 @@ win_print_outgoing(ProfWin* window, const char* show_char, const char* const id,
_win_correct(window, message, id, replace_id, myjid);
} else {
//TODO my jid
- _win_printf(window, show_char, 0, timestamp, 0, THEME_TEXT_THEM, "me", myjid, id, "%s", message);
+ _win_printf(window, show_char, 0, timestamp, 0, THEME_TEXT_ME, "me", myjid, id, "%s", message);
}
inp_nonblocking(TRUE); |
What do you mean? |
I mean that |
@aba-hollerer but in my screenshot it looks correct, doesn't it? |
@aba-hollerer are you sending from two different instances here? Then, I'm able to reproduce it like (in a MUC): (@jubalh is this expected?)
I think we're just trying to understand what this solves :) |
@wstrm: No this was on the same instance. |
Your patch looks right to me on first glance. The point is to verify the root cause of this. Is it a misunderstanding? Is it an error that you found and solved? Is it another error and your solution is only covering it up? As stated above we cannot reproduce this issue on our side (both @wstrm and me), which is suspicious don't you agree? Like you saw in the code there are many cases. I also think that it is possible that you send with another client/instance and thus carbons are used. |
So I dug a little further in src/ui/window.c. The problem seems not to be present for MUC:
But in win_print_outging:
|
I still don't see why I couldn't reproduce it. But I think you are right. The mistake seems to be introduced in b6b7dd5 |
I have |
Thanks for your investigations @aba-hollerer ! |
Thank you for maintaining such an awesome piece of software:) |
Expected Behavior
I'd expect that setting main.text.me different to main.text.them in a theme would result in two different colors.
Current Behavior
I am setting main.text.me=white and main.text.them=blue but I always get blue.
Possible Solution
Steps to Reproduce (for bugs)
Context
It's not critical or anything I just thought somebody should know.
Environment
profanity -v
Profanity, version 0.9.5
Copyright (C) 2012 - 2019 James Booth boothj5web@gmail.com.
Copyright (C) 2019 - 2020 Michael Vetter jubalh@iodoru.org.
License GPLv3+: GNU GPL version 3 or later https://www.gnu.org/licenses/gpl.html
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Disabled
PGP support: Disabled
OMEMO support: Disabled
C plugins: Enabled
Python plugins: Enabled (3.7.9)
GTK icons: Enabled
Gentoo amd64
ldd (Gentoo 2.32-r2 p2) 2.32
The text was updated successfully, but these errors were encountered: