Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check for OMEMO device id for JIDs banned of a MUC #1594

Closed
pmaziere opened this issue Aug 31, 2021 · 2 comments
Closed

Do not check for OMEMO device id for JIDs banned of a MUC #1594

pmaziere opened this issue Aug 31, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@pmaziere
Copy link
Contributor

I recently had an issue with my prosody server that kept trace of a banned user among the participant of a private MUC.
This resulted in profanity spitting "Can't find a OMEMO device id for <banned_JID>." each time I was sending a message in the MUC. Removing the banned JID in the relevant MUC related file on the server side and restarting profanity prevented this annoying error message to come back.

I then realized that it does not make sense for profanity to check for OMEMO device id of MUC banned JIDs.
But that may trigger some security issues that I'm not aware of, so I let this discussion to the OMEMO gurus :)

Thanks again for this great piece of useful software !

@jubalh jubalh added the OMEMO label Aug 31, 2021
@jubalh jubalh added this to the 0.12.0 milestone Aug 31, 2021
@jubalh
Copy link
Member

jubalh commented Sep 28, 2021

@paulfariello does this make sense?

@jubalh jubalh self-assigned this Feb 2, 2022
@jubalh jubalh closed this as completed in 6d1c661 Feb 2, 2022
@jubalh
Copy link
Member

jubalh commented Feb 2, 2022

We go through all members in https://github.com/profanity-im/profanity/blob/master/src/omemo/omemo.c#L783
When a ban occured it seems we never removed the person from the members list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants