Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting avatar executable to gio open crashes Profanity #1742

Closed
jubalh opened this issue Aug 2, 2022 · 1 comment
Closed

Setting avatar executable to gio open crashes Profanity #1742

jubalh opened this issue Aug 2, 2022 · 1 comment
Labels
bug
Milestone
0.13.0

Comments

@jubalh
Copy link
Member

jubalh commented Aug 2, 2022

It works with url open but doesnt for avatar.

Expected Behavior

/executable avatar "gio open" should set gio open as default opener for /avatar open.

Current Behavior

Crash

Possible Solution

Check GSubprocess instead of spawn.

Steps to Reproduce (for bugs)

  1. /executable urlopen set "gio open %u"

  2. `/url open ..select one

  3. it works

  4. /executable avatar "gio open""`

  5. /avatar open somejid

  6. crash

Environment

9d094f7
@jubalh jubalh added the bug label Aug 2, 2022
@jubalh jubalh added this to the 0.13.0 milestone Aug 2, 2022
@nandesu-utils nandesu-utils mentioned this issue Aug 24, 2022
Merged
@jubalh jubalh closed this as completed in 359e261 Sep 6, 2022
@jubalh
Copy link
Member Author

jubalh commented Sep 6, 2022

Thanks @nandesu-utils !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
1 participant
@jubalh