Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated cmocka Functions #1907

Closed
ike08 opened this issue Oct 31, 2023 · 2 comments · Fixed by #1908
Closed

Deprecated cmocka Functions #1907

ike08 opened this issue Oct 31, 2023 · 2 comments · Fixed by #1908
Assignees
@ike08
Labels
tests
Milestone
next

Comments

@ike08
Copy link
Contributor

ike08 commented Oct 31, 2023

Profanity is using deprecated cmocka functions described here.

What do you think about replacing them with current supported functions?
@ike08 ike08 changed the title Depricated cmocka Functions Deprecated cmocka Functions Oct 31, 2023
@jubalh
Copy link
Member

jubalh commented Oct 31, 2023

Profanity is using deprecated cmocka functions described here.

I wasn't aware.

What do you think about replacing them with current supported functions?

That sure would make sense.

@ike08
Copy link
Contributor Author

ike08 commented Nov 1, 2023

The contributor didn't explain why they created a new test runner in their commit.

At first glance, it should be easy to switch over to the new test runner. I'll submit a PR after I give it a try.

@ike08 ike08 mentioned this issue Nov 2, 2023
Merged
@jubalh jubalh added the tests label Nov 2, 2023
@jubalh jubalh added this to the next milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ike08 ike08

Labels
tests
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

Refactor tests to use the new cmocka test runner
2 participants
@jubalh @ike08