-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustls 0.22 support #103
Comments
I would like to add that the rustls and openssl interfaces where never quite the same in the first place so for me this wouldn't be that big of an issue, and since axum_server is pre-v1.0.0 we can probably justify a breaking change while moving to v0.7.0. |
I opened a draft PR in #106, if anyone else would like to have a look or test the changes. It's a draft because I'm not sure if it's a good idea to land breaking changes since 0.6 just came out. |
Just looked into it @eric-seppanen make this a PR, it should be fine |
Note that this got fixed in rustls-pki-types 1.4.0: |
I had a look at the reverted support for
rustls
0.22, which should be unblocked now thattokio-rustls
0.25 has been released.However, I found one change in
rustls
0.22 that might force a breaking change toaxum-server
.The problem lies here:
The problem is that you can no longer build a ServerConfig directly from a private key in DER
Vec<u8>
form unless you know which flavor the key is. The expected input to a rustlsConfigBuilder
is aPrivateKeyDer
, which is defined asand there's no way to get a
PrivateKeyDer
from aVec<u8>
.Is
axum-server
committed to this interface? It would be easier to implement this instead:but that would mean that the rustls and openssl interfaces diverge.
config_from_pem
can stay the way it is, becauserustls_pemfile
functions returnPrivateKeyDer
values.The text was updated successfully, but these errors were encountered: