Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a new version and push to crates.io #5

Closed
stranger-danger-zamu opened this issue Sep 15, 2022 · 3 comments · Fixed by #6
Closed

Cut a new version and push to crates.io #5

stranger-danger-zamu opened this issue Sep 15, 2022 · 3 comments · Fixed by #6

Comments

@stranger-danger-zamu
Copy link

Crates.io is still using the original v0.2.0 release (#2 ea69651) which will conflict with the latest rusqlite version. The latest commit from August (#4 33914f8) which updates Cargo.toml dependencies versions fixes it. This however was never pushed up to crates.io.

@programatik29
Copy link
Owner

This would require a minor version bump which might be fine. But I would like to decide how to deal with conflicting versions first. I am currently leaning toward re-exporting rusqlite and exposing its features in this crate.

@stranger-danger-zamu
Copy link
Author

stranger-danger-zamu commented Sep 16, 2022

I'm not sure what the best answer is, but I feel that it wouldn't particularly help in the grand scheme of things.

There still could be conflicting versions for projects depending on this library even if you re-export rusqlite. For example even if I wasn't depending on rusqlite directly I am still using serde_rusqlite which would cause the same issue.

On the other hand, if rusqlite was re-exported I wouldn't have noticed this being an issue. If or when I added serde_rusqlite it might've made the figuring out the root cause more difficult like during the early days of tokio.

Either way you go about it works for me, just adding my two cents.

@programatik29
Copy link
Owner

I will just bump up the version and publish it to keep it simple.

@programatik29 programatik29 linked a pull request Sep 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants