Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: LABEL all images / containers created by Envy #10

Open
fgrehm opened this issue Jun 25, 2015 · 4 comments
Open

Proposal: LABEL all images / containers created by Envy #10

fgrehm opened this issue Jun 25, 2015 · 4 comments

Comments

@fgrehm
Copy link
Contributor

fgrehm commented Jun 25, 2015

I've spent some time hacking on the project and as a result I now have lots and lots of "trash" on my Docker instance. It would be nice if we had an easy way to 💣 them all with one or two commands like:

docker rm -f $(docker ps -q -f 'label=envy')
docker rmi $(docker images -f 'label=envy')

Any thoughts on that?

@progrium
Copy link
Owner

Yeah that's easy for containers but there isn't a way to add labels to an image other than in the Dockerfile right? I don't want to mess with appending to the Dockerfile ...

What did the trash consist of mostly? Maybe it just needs to do a better job cleaning up?

@fgrehm
Copy link
Contributor Author

fgrehm commented Jun 25, 2015

Yeah that's easy for containers but there isn't a way to add labels to an image other than in the Dockerfile right? I don't want to mess with appending to the Dockerfile ...

We can docker run -l envy=true ... 😏

What did the trash consist of mostly? Maybe it just needs to do a better job cleaning up?

I was hacking on the stuff I mentioned to you on twitter so I did not pay much attention to what was going on. BUT, I do remember having errors while iterating on the changes I was making so it might be that Envy can't handle that properly (or I messed something up with my local changes)

The leftovers were basically stopped and running containers. Some of them were actually running after I closed the browser, can't remember if it happened over SSH since I haven't used it that much.

I'll pay more attention to that and will try to find out the reason behind it 🍻

@fgrehm
Copy link
Contributor Author

fgrehm commented Jun 25, 2015

Yeah that's easy for containers but there isn't a way to add labels to an image other than in the Dockerfile right? I don't want to mess with appending to the Dockerfile ...

My bad, I misunderstood you on that one. You are right, labeling images is not possible besides messing up with the Dockerfile :(

@progrium
Copy link
Owner

The hterm package is slightly incomplete in handling closed websockets. We want that to cleanup those sessions, so that should be filed as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants