Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockLeavesBase doesn't extends BlockLeaves? #424

Closed
ghost opened this issue Jan 9, 2018 · 3 comments
Closed

BlockLeavesBase doesn't extends BlockLeaves? #424

ghost opened this issue Jan 9, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 9, 2018

then it's incompatible with other mods that reads it as a leave. for example passable leaves installed, player cant pass natura leaves. another example, better foliage mod; theres no extra leaves on natura leaves... plz fix this.
octarine-noise/BetterFoliage#164
OreCruncher/DynamicSurroundings#199
@KnightMiner
Copy link
Collaborator

KnightMiner commented Jan 10, 2018 •
edited

Those mods should really be calling Block::isLeaves then instead of doing an instanceof check. Why do it the hard way when there is a base method?

@ghost
Copy link
Author

ghost commented Jan 10, 2018

thanks a LOT!

This was referenced Jan 10, 2018
Closed
Closed
@octarine-noise
Copy link

That's actually a very good point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@octarine-noise @KnightMiner