Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I modified everything to work with upcoming OpenCV 4. changes #15

Closed
TechnikEmpire opened this issue Oct 14, 2018 · 3 comments
Closed

I modified everything to work with upcoming OpenCV 4. changes #15

TechnikEmpire opened this issue Oct 14, 2018 · 3 comments

Comments

@TechnikEmpire
Copy link
Contributor

Do you want a PR? I'm not sure I can't even use the library but I made the changes first, thought about it later. So I can send if you want them.
@ereator
Copy link
Member

ereator commented Oct 15, 2018

Yes, please make a pull request, I will test whether all demos and unit test running and merge your changes into the master. Thank you very much for you contribution.

@TechnikEmpire
Copy link
Contributor Author

Unit tests pass but I didn't try demos. Will submit a PR today.

@TechnikEmpire
Copy link
Contributor Author

Probably submitted and merged so I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TechnikEmpire @ereator