Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute workloads based on labels instead of flags in PR titles #334

Closed
kate-goldenring opened this issue May 14, 2021 · 2 comments · Fixed by #426
Closed

Execute workloads based on labels instead of flags in PR titles #334

kate-goldenring opened this issue May 14, 2021 · 2 comments · Fixed by #426
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kate-goldenring
Copy link
Contributor

Currently, certain workflows are being skipped/executed based on flags set in PR titles. For example, adding [SAME VERSION] to a PR title prevents the version check workflow from running. However, after adding a flag to a title, checks cannot simply be re-run, since they refer to the state of the PR of the last commit. Resultingly, another commit must be pushed to the PR in order for checks to properly register the PR title change (and therefore flag). Running workflows based on labels instead of flags may remove this issue of pushing new commits.

Work to be done:

  1. Confirm whether actions can reference newly added labels without new commits needing to be pushed. (Even if this isnt the case, labels are still cleaner than PR title flags)
  2. In the opencv base build, rust base build, and version check workflows, github.event.pull_request.title should be changed to github.event.label.name and point to newly made labels (possibly same version, allow intermediate builds, and ignore intermediate builds).
  3. Update PR template and contributing doc to explain this new model
@kate-goldenring kate-goldenring added good first issue Good for newcomers help wanted Extra attention is needed labels May 14, 2021
@kate-goldenring kate-goldenring added this to Triage needed in Akri Roadmap May 20, 2021
@vincepnguyen
Copy link
Collaborator

I will investigate this issue

@kate-goldenring kate-goldenring moved this from Triage needed to In progress in Akri Roadmap Aug 3, 2021
@kate-goldenring kate-goldenring linked a pull request Sep 1, 2021 that will close this issue
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Issue has been automatically marked as stale due to inactivity for 45 days. Update the issue to remove label, otherwise it will be automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
3 participants