Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Continue session has changed ? #682

Closed
LazzaAU opened this issue Sep 20, 2022 · 1 comment
Closed

[BUG]: Continue session has changed ? #682

LazzaAU opened this issue Sep 20, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@LazzaAU
Copy link
Contributor

LazzaAU commented Sep 20, 2022

Description of the bug

Correct me if i'm wrong but ,,, If you try to self.continueDialog() i'm pretty sure from memory it used to append the continued dialog into the existing session data ? how ever i've noticed since making a recent skill and also looking at why reminder skill has stopped that when i use something like

self.continueDialog(
				sessionId=session.sessionId,
				text=self.randomTalk(text='respondReminderMessage', replace=[self._eventType]),
				intentFilter=[self._INTENT_USER_RANDOM_ANSWER],
				currentDialogState='AddMessageToReminder'
			)

the method that receives the User random answer in this case has only the user random answer data in print(session) when i'm expecting to see the previous session data AND the user Random answer session all merged into the one ?

i can get around it by adding required values to customData before calling a continueDialog but dont recall needing to in the past ?

Is this normal now or something that's gone Bang ?

Steps To Reproduce

  1. invoke a session
  2. in the @intenthandler method add a continueDialog function calling user random answer (URA)
  3. print the session of the resulting URA
  4. does it still include original session intent data ? EG: slotsAsObjects and intent etc

Additional Information

No response

@LazzaAU LazzaAU added the bug Something isn't working label Sep 20, 2022
@LazzaAU
Copy link
Contributor Author

LazzaAU commented Sep 21, 2022

Just answering my own report :). Think it's a result of asking via dialog view as opposed to a voice request. Will update skill code to use both options. But maybe worth looking at for the new dialog re work... ie allow continued convo via dialogview shrug

@LazzaAU LazzaAU closed this as completed Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant