Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IM/DM] More intelligent reporting on subscriptions #166

Open
ivmarkov opened this issue May 22, 2024 · 0 comments
Open

[IM/DM] More intelligent reporting on subscriptions #166

ivmarkov opened this issue May 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ivmarkov
Copy link
Contributor

Since the merge of #147 , we now do have subscriptions and we do report on these.

However, the current implementation is a bit suboptimal, in that it always reports everything, regardless whether any of the attributes reported by the subscription are actually changed.

I also believe that the existing ChangeNotifier idea, which is somewhat implemented throughout the code (but unfinished), might not have a future, as I don't see it helping in anyway to solve the problem:

  • When we get a write or invoke command from a remote peer, we are anyway notified via the AsyncHandler callbacks.
  • When we are modifying the data ourselves, we actually know we are doing this, so we don't need an eager notification from the cluster calling back into us, when the cluster dataver is changed

I think something more fruitful would be if the notification is traversing all clusters it reports on, and trying to detect (possibly by comparing against a preserved set of datavers, or a simpler -hash-based derivation of multiple datavers) if there are changes or not.

@ivmarkov ivmarkov added the enhancement New feature or request label May 22, 2024
@ivmarkov ivmarkov changed the title More intelligent reporting on subscriptions [IM/DM] More intelligent reporting on subscriptions Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant