-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly implement SDK-extensions UI features #177
Comments
This is a bit of a larger item.... The problem is the following: We have a feature called SDK extensions, where SDK can add their own data points to the individual fields. This will then result in ZAP showing a new column for the attribute, based on this data point (which is stored in the DB.) We have the mechanism to load these into the database, we also have the queries, I think there is also REST API calls for that (and if not, they are easy to add). But the UI doesn't do this now. |
See this part of the "SDK customization" doc: https://github.com/project-chip/zap/blob/master/docs/sdk-integration.md#template-key-zcl This lists the custom "zcl" keys in the
In terms what APIs already exist:
There are unit tests for this see gen-zigbee.test.js which has this:
This tests that the extensions are properly triggered and generated. |
For a good example of how these "extensions" are added to the system, see: It has the "zcl" key which defines the extensions:
This one, for example is "hidden", so it should not show in the UI. If you change this "configurability" to "visible", it should show in the UI for each cluster. This file actually drives the unit tests, so feel free to add more extensions in here with different configurability. I also expect, once you show them in the ui, we might need more data around it, such as "uiType: number" or maybe "uiType: checkbox" and so on. If you run into this, let me know and we can add more metadata around these extensions. |
@Mehradml : here is my belief of what kind of APIs we have... 1.) query-package.js has these queries:
I think as far as queries go, these are all that are needed. 2.) There is a REST API in
I think this is the only one. It can be used to query extensions. Should return some JSON stuff. |
We have added a lot of new XML elements. We need UI for them. This issue is a placeholder for all that.
The text was updated successfully, but these errors were encountered: