Refactor configuration utility tool; added support for latest Ray version #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Extending #37
What does this PR do?
This PR extends the Ray resiliency config tool. The PR does the following:
The Ray config utility script now supports configurations from Ray v1.6, 1.7, and 1.8.
The tool now saves config. files into their respective version directory. This is more organized as compared to saving files from all Ray versions into a single folder.
For example, now the tools save output config. files in the following manner by default.
├── configs
│ ├── 1.0.0
│ │ ├── Ray 1.0.0 related config files
│ ├── 1.1.0
│ │ └── Ray 1.1.0 related config files
The configuration parsing code is more generalized than before. Removed some hard-coded conditions and added functions to make the code less cluttered.
Added a new field called
config_string
in the output config file. This field stores the original string from which we parsed the default value of the configuration. Theconfig_string
stores string whenever the default value is not a simple value but a conditional statement. This field will help in explaining how the associated environment variable's value will determine the default value.For example:
For
raylet_start_wait_time_s
configuration, the signature/input is following:And, the script dumps following Yaml entry in the .conf file:
The new field i.e.
config_string
is informatory and gives an idea about how the associated environment variable will be processed.system_cm.yaml
)