Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] flag to continue when there are errors #203

Closed
sozercan opened this issue Jul 13, 2023 · 3 comments · Fixed by #247
Closed

[REQ] flag to continue when there are errors #203

sozercan opened this issue Jul 13, 2023 · 3 comments · Fixed by #247
Assignees
Labels
enhancement New feature or request

Comments

@sozercan
Copy link
Member

sozercan commented Jul 13, 2023

What kind of request is this?

New feature

What is your request or suggestion?

today, we fail patching if any package fails to patch

if patching fails for a package for whatever reason, we might want to continue anyway to produce an image

@sozercan sozercan added the enhancement New feature or request label Jul 13, 2023
@anubhav06
Copy link
Contributor

If no one is working on this issue, then can I work on this?
How about a flag named --force-patching?

@sozercan
Copy link
Member Author

@anubhav06 Thanks! I will assign to you.

Just for context, I was thinking we can approach this in a few ways:

  1. (this issue) Scenario: Teams wants to patch an image ASAP but there are failures for some reason, but it's better to have something than nothing. This is where the flag comes in for fast resolution.
    For the flag, should we align with flags that already exists in other tools? For example, GH calls this continue-on-error and make has --ignore-errors. What do you think?

  2. ([DOC] filtering vulns with trivy #214) Scenario: There is a known failure for some reason. So teams just want to ignore that CVE/package in their CI instead of ignoring all errors. This is more documentation on how to create policy to create filters with scanner tooling.

@anubhav06
Copy link
Contributor

  1. Yes. I think if we align with the existing flags from tools that already exist, that would be a better option. Both of them sounds good to me. I'll proceed with --ignore-errors flag for now. Let me know if you want me to name it something else.
  2. I'll update the documentation for that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants