Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kafka trigger example #65

Closed
rameshpolishetti opened this issue Jul 8, 2019 · 5 comments · Fixed by #67
Closed

Add Kafka trigger example #65

rameshpolishetti opened this issue Jul 8, 2019 · 5 comments · Fixed by #67
Assignees
Labels
enhancement New feature or request

Comments

@rameshpolishetti
Copy link
Contributor

rameshpolishetti commented Jul 8, 2019

Current behavior:
Currently, we have only rest trigger based examples

Expected behavior:
Add kafka trigger based example, describing how a Kafka message can be input source to rule action & how kafka topic and messages are mapped to tuple type and data.

@rameshpolishetti rameshpolishetti added the enhancement New feature or request label Jul 8, 2019
@mellistibco
Copy link
Member

mellistibco commented Jul 8, 2019

I don't understand this enhancement request. Flogo Rules should support any Flogo trigger. Why are we suggesting to implement the exact the same thing already implemented in flogo core? If someone wants to trigger a flogo rules app from any source, they should be using flogo rules as an action in a flogo application and hence get the ability to trigger the rules via any available trigger in the flogo ecosystem.

@rameshpolishetti
Copy link
Contributor Author

@mellistibco It's my bad. I didn't mean to add same Kafka trigger here instead add an example for kafka channel and update rules/action input parameters (for mapping, only if required). Let me update the issue title/description accordingly.

@rameshpolishetti rameshpolishetti changed the title Add Kafka channel support Add Kafka channel example Jul 9, 2019
@mellistibco
Copy link
Member

i think we need to clean up terminology also. we need to keep things consistent. A channel is basically the same thing as a trigger, can we work on cleaning up terminology both in code and in documentation? I can't think of any reason to have multiple overlapping terms. Flogo has standardized on triggers and we should stick with that as a way to define/describe an input source into an action.

@rameshpolishetti
Copy link
Contributor Author

@mellistibco agreed, updating the issue terminology accordingly.
Don't want to dilute the original objective of this issue. Can we take up fixing any terminology deviations as a different issue?

@rameshpolishetti rameshpolishetti changed the title Add Kafka channel example Add Kafka trigger example Jul 10, 2019
@mellistibco
Copy link
Member

@rameshpolishetti yes, let's create a different issue to capture and track the larger task of fixing terminology, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants