Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rds data (non-RData, csv or txt) to data or vignette #3

Closed
ohagen opened this issue Apr 2, 2020 · 8 comments
Closed

add rds data (non-RData, csv or txt) to data or vignette #3

ohagen opened this issue Apr 2, 2020 · 8 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@ohagen
Copy link
Member

ohagen commented Apr 2, 2020

https://stackoverflow.com/questions/36237991/r-can-i-use-rds-files-for-my-data-in-a-package

@ohagen ohagen added documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 2, 2020
@florianhartig
Copy link
Member

no, this is the wrong discussion, raw data should go in data-raw

@florianhartig
Copy link
Member

sorry, no, probably better to put it in extdata http://r-pkgs.had.co.nz/data.html#data-extdata, I have to try this.

data-raw is also possible, but then we would probably have to build the vignette by hand and move it, as we do in https://github.com/COST-FP1304-PROFOUND/ProfoundData/tree/master/ProfoundData/data-raw

@florianhartig
Copy link
Member

Yes, I think this works best, see also https://stackoverflow.com/questions/13463103/inst-and-extdata-folders-in-r-packaging?noredirect=1&lq=1

I can do this, but will wait for what you say about the vignette.

@ohagen
Copy link
Member Author

ohagen commented Apr 6, 2020

Please give it a shot. I am at the very start of the vignettes and having a robust order now will help a lot. I like this: https://stackoverflow.com/questions/13463103/inst-and-extdata-folders-in-r-packaging?noredirect=1&lq=1
Wecan call fpath <- system.file("extdata", "my_raw_data.csv", package="my_package") on the vignette! Go ahead and I will pull when you are ready.

@ohagen
Copy link
Member Author

ohagen commented Apr 6, 2020

Florian, I changed the file to the order on the forums that you pointed out. But now compiling vignette introduction is crashing. can you have a look at how I am calling the functions. Precisely at line 98 is the first error reading the config file. I tried to use the line that gets the absolute path within the package:
datapath <- system.file("extdata", "EXPERIMENT_X", package="gen3sis")

@florianhartig
Copy link
Member

I'll have a look in the next days, swamped at the moment, sorry!

@ohagen
Copy link
Member Author

ohagen commented Apr 7, 2020

No worries. Thanks a lot!

@ohagen
Copy link
Member Author

ohagen commented Apr 7, 2020

I think I found a work around! Vignette works as intended. Thus closing the issue. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants