-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality assurance of the MONAI/examples folder #101
Comments
@wyli Regarding the python files, we can setup running them during CI/CD right, but wont executing each file take time and increase build time? |
yes, with this feature implemented, the CI/CD is likely to take significantly more time. but I think we should address it with a separate ticket (e.g. refactoring the CI job configures so that they could run in parallel and take less time). for this ticket we need to implement some initial pipelines (welcome discussions) for:
the notebooks are trickier (see also Project-MONAI/MONAI#874), there are some discussions in https://github.com/Project-MONAI/MONAI/issues/296 of the relevant tools but we still need to check their feasibility for our use case |
Thanks for the explanation. Regarding checking the syntax error, we can simply execute the python file during the CI/CD "python filename.py" and then give it some upper execution time limit? Also, if I can be of help here, I would like to contribute to some of the points mentioned above. |
thanks @arp95, would be great to have a simple |
sure. i will work on the shell script and then raise a pull request. |
@wyli i was running the file "densenet_training_array.py". It requires the data to be downloaded from this website, https://brain-development.org/ixi-dataset/. Should we save the data in some MONAI google drive for online running or is there another way around this? Because we cant expect to be downloading data everytime during the CI/CD build right? |
I put those demo data here: https://www.dropbox.com/s/y890gb6axzzqff5/testing_ixi_t1.tar.gz?dl=1 please let me know if there's further issue |
thanks for the help. will check it out and let you know if I face any issues. |
…es/classification_3d and examples/classification_3d_ignite folders
…d examples/classification_3d_ignite folders
…iles (#891) * Worked on issue #806: Added more test cases for densenet, updated test_densenet.py files in tests folder * Worked on issue #806: Added more test cases for densenet, updated test_densenet.py files in tests folder * Worked on issue #872: Added script for running python files in examples/classification_3d and examples/classification_3d_ignite folders * Worked on issue #872: Modified files in examples/classification_3d and examples/classification_3d_ignite folders * Worked on issue #872: Modified files in examples/ folder and updated runexamples.sh script * Worked on issue #872: Updated python files in examples folder * Worked on issue #872: Modified files in examples folder * Worked on issue #806: Modified runexamples.sh script * Update runexamples.sh
addressed by #107 , please file new issues for any follow-up |
Is your feature request related to a problem? Please describe.
As the size and content scope of the
MONAI/examples
folder increase,it's necessary to figure out the hardware/software requirements for running the examples,
and also provide some forms of quality assurance of the example codes.
Describe the solution you'd like
could automatically run the examples as a part of the automated CI/CD pipeline?
Describe alternatives you've considered
manually verifying all the examples regularly (tedious and error-prone)
Additional context
see also https://github.com/Project-MONAI/MONAI/issues/296
The text was updated successfully, but these errors were encountered: