Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Multi region support #30

Merged
merged 4 commits into from
May 15, 2023
Merged

feat: Multi region support #30

merged 4 commits into from
May 15, 2023

Conversation

dskart
Copy link
Collaborator

@dskart dskart commented May 11, 2023 •
edited
Loading

What

  • allows aws requests to work across different regions
  • adds unit and integration tests for multi-region support

@dskart dskart requested a review from kmushegi May 11, 2023 20:37
kmushegi
kmushegi reviewed May 12, 2023
View reviewed changes
boltrouter/main_test.go Outdated Show resolved Hide resolved
kmushegi
kmushegi reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@kmushegi kmushegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall and tested w aws cli on linux

@dskart dskart requested a review from kmushegi May 12, 2023 15:48
@dskart dskart merged commit bb62e1e into main May 15, 2023
5 checks passed
@dskart dskart deleted the multi-region-aws-client branch May 15, 2023 17:57
@github-actions github-actions bot mentioned this pull request May 15, 2023
Merged
This was referenced Aug 15, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmushegi kmushegi Awaiting requested review from kmushegi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dskart @kmushegi