feat: refresh AWS credentials periodically #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… static creds on the machine, no need to waste compute refreshing
kmushegi
force-pushed
the
feat/refresh-aws-credentials-periodically
branch
from
54b13cf
to
72b41a2
Compare
dskart
requested changes
May 15, 2023
boltrouter/aws_credentials_client.go
Outdated
| awsCredentialsMap.Store(awsConfig.Region, cred) | ||
| return cred, nil | ||
| } | ||
|
|
||
| func (br *BoltRouter) RefreshAWSCredentials(ctx context.Context) error { |
There was a problem hiding this comment.
is there a reason for this method to be part of BoltRouter? can we make it private?
There was a problem hiding this comment.
nope vestigial, made private.
dskart
approved these changes
May 15, 2023
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh AWS credentials in Bolt router every 30 minutes since on EC2 the temporary credentials have a 1 hour expiration.