Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KRY-634): Add sidekick local run to support local bolt endpoint #49

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

avasani
Copy link
Contributor

@avasani avasani commented Jul 19, 2023

This commit introduces support for specifying a local IP address in the SideKick when running in local mode. It allows the BoltRouter to construct the BoltEndpoints using the local IP address and points both main and failover endpoints to the same port (9000).

This would be useful to these locally since bolt and sidekick would be running on samehost.

Unit Test:

  • Run Sidekick in local mode
$ docker run -p 7075:7075 --env GRANICA_CUSTOM_DOMAIN=localhost --env AWS_REGION="us-east-1" -v ~/.aws/:/root/.aws/ sidekick:latest serve -l --bolt-endpoint-override 192.168.1.183:9000 -f
  • Validate S3 access
$ aws s3api list-buckets    --endpoint-url http://localhost:7075/
{
    "Buckets": [
        {
            "Name": "n-data-in1",
            "CreationDate": "2023-07-18T14:16:05.360000+00:00"
        },
        {
            "Name": "in1",
            "CreationDate": "2023-07-18T14:16:05.364000+00:00"
        },
        {
            "Name": "n-virtual-recyclebin",
            "CreationDate": "2023-07-17T21:25:02.407000+00:00"
        }
    ],
    "Owner": {
        "DisplayName": "s3server",
        "ID": "fe7272ea58be830e56fe1663b10fafef"
    }
}

@avasani avasani requested review from kmushegi and dskart July 19, 2023 00:37
cmd/serve.go Outdated Show resolved Hide resolved
@kmushegi
Copy link
Contributor

Also peep the readme for conventional commits formatting: https://github.com/project-n-oss/sidekick#commits

cmd/serve.go Outdated Show resolved Hide resolved
@avasani avasani changed the title Add sidekick local run support feat(KRY-634): Add sidekick local run to support local bolt endpoint Jul 19, 2023
@dskart
Copy link
Collaborator

dskart commented Jul 20, 2023

Looks good but make sure that your commits follow the https://www.conventionalcommits.org/en/v1.0.0/ format!

@avasani
Copy link
Contributor Author

avasani commented Jul 20, 2023

Looks good but make sure that your commits follow the https://www.conventionalcommits.org/en/v1.0.0/ format!

Fixed. I also rebased the code with @kmushegi 's changes.

Copy link
Contributor

@kmushegi kmushegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I think you'll need to rebase once more!

@avasani avasani merged commit 7bf67c7 into main Jul 20, 2023
5 checks passed
@avasani avasani deleted the avasani/enable-sk-locally branch July 20, 2023 23:43
This was referenced Jul 20, 2023
kmushegi added a commit that referenced this pull request Jul 26, 2023
kmushegi added a commit that referenced this pull request Jul 26, 2023
This was referenced Aug 15, 2023
@avasani avasani restored the avasani/enable-sk-locally branch August 18, 2023 06:27
@dskart dskart deleted the avasani/enable-sk-locally branch May 24, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants