-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KRY-634): Add sidekick local run to support local bolt endpoint #49
Conversation
Also peep the readme for conventional commits formatting: https://github.com/project-n-oss/sidekick#commits |
b4b1d30
to
ccdc575
Compare
Looks good but make sure that your commits follow the https://www.conventionalcommits.org/en/v1.0.0/ format! |
89afc43
to
988e7cf
Compare
988e7cf
to
5ba8407
Compare
5ba8407
to
f59e151
Compare
Fixed. I also rebased the code with @kmushegi 's changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I think you'll need to rebase once more!
f59e151
to
f861e3f
Compare
f861e3f
to
d1517cb
Compare
d1517cb
to
594b312
Compare
This commit introduces support for specifying a local IP address in the SideKick when running in local mode. It allows the BoltRouter to construct the BoltEndpoints using the local IP address and points both main and failover endpoints to the same port (9000).
This would be useful to these locally since bolt and sidekick would be running on samehost.
Unit Test: