Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return proper error if boltInfo is empty #63

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

kmushegi
Copy link
Contributor

@kmushegi kmushegi commented Jul 26, 2023

What it Does

Check if boltInfo is empty (this can happen when Quicksilver is down or returning nothing) and return an appropriate error.

Previously this was bubbling up as

level":"ERROR","ts":"2023-07-25:23:28:22.188","caller":"api/api.go:62","msg":"internal error","request_id":"hPbxEnzHaa_1oUrWq9VqMbfmCL0","user_agent":"Boto3/1.28.5 md/Botocore#1.31.5 ua/2.0 os/linux#4.14.318-241.531.amzn2.x86_64 md/arch#x86_64 lang/python#3.7.16 md/pyimpl#CPython cfg/retry-mode#legacy Botocore/1.31.5","error":"could not cast availableEndpoints to []string"}

and now the error log printed is

{"level":"ERROR","ts":"2023-07-26:01:08:21.203","caller":"api/api.go:62","msg":"internal error","request_id":"KLPqhpH1UAno6dcGkULV-ArSpPM","user_agent":"aws-cli/2.9.19 Python/3.9.16 Linux/6.1.34-59.116.amzn2023.x86_64 source/x86_64.amzn.2023 prompt/off command/s3api.get-object","error":"boltInfo is empty"}

@cv-projectn
Copy link
Contributor

This means QuickSilver is unavailable. Should we redirect to S3?

@kmushegi
Copy link
Contributor Author

This means QuickSilver is unavailable. Should we redirect to S3?

Let's go one step at a time, not straightforward at the moment to redirect to s3 rn.

@kmushegi kmushegi merged commit 83a35cb into main Jul 26, 2023
7 checks passed
@kmushegi kmushegi deleted the kote/feat/proper-response-when-no-endpoints branch July 26, 2023 17:35
This was referenced Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants