Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range tool on index based charts #98

Open
4 tasks done
mariusvigariu opened this issue Oct 28, 2023 · 0 comments
Open
4 tasks done

Range tool on index based charts #98

mariusvigariu opened this issue Oct 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mariusvigariu
Copy link

Describe the bug

I reckon this is low prio, but placing it here for future reference, the range tool on index based charts is not working. I assume it needs to be adjusted a little bit since x and y values of the pins are not properly computed for index based charts

Reproduction

https://github.com/project-nv/night-vision/blob/main/src/scripts/tools/RangeTool.navy#L15

Steps to reproduce

  1. spin up a chart with some dummy data
  2. add the tool range
  3. make the chart non index based
  4. see it's working
  5. make the chart index based
  6. see it's not working

Javascript Framework

no-framework (vanilla-js)

Logs

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a NightVision issue and not a framework-specific issue.
  • The provided reproduction is a minimal reproducible example of the bug.
@C451 C451 added the bug Something isn't working label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants