Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate making rust-protobuf no_std compatible #550

Closed
blaxill opened this issue Feb 4, 2020 · 1 comment
Closed

Investigate making rust-protobuf no_std compatible #550

blaxill opened this issue Feb 4, 2020 · 1 comment
Projects

Comments

@blaxill
Copy link
Contributor

blaxill commented Feb 4, 2020

It should be possible to make rust-protobuf no_std compatible. There are different approaches we could take either:

  • Use no-std-compat or similar to compile rust-protobuf to no_std. This would potentially be the least amount of work, but likely would require vendoring rust-protobuf under third_party/ and re-adding the std::prelude import to all the files (as no_std removes the implicit prelude import)
  • Edit all files to use alloc / core and fix any remaining issues manually. Hopefully as automated as possible.

If it is not viable to move rust-protobuf to no_std, then we may be required to move to a different library such as prost.

@tiziano88 tiziano88 added this to To do in planning via automation Feb 10, 2020
@daviddrysdale
Copy link
Contributor

We moved to Prost everywhere in #829, and away from Asylo in #709 – is this still relevant?

@blaxill blaxill closed this as completed Apr 21, 2020
planning automation moved this from To do to Done Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
planning
  
Done
Development

No branches or pull requests

3 participants