Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked items can be split in bag #576

Closed
TheTinkeringIdiot opened this issue Jan 29, 2024 · 5 comments
Closed

Stacked items can be split in bag #576

TheTinkeringIdiot opened this issue Jan 29, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@TheTinkeringIdiot
Copy link
Collaborator

Describe the bug
A stacked item like ammo can be split while inside of a bag. The split items cannot be removed from the bag, but the original stack can. The two stacks cannot be recombined in the bag, and when the bag closes, the split items are destroyed.

To Reproduce
Steps to reproduce the behavior:

  1. Place a stack of items in a bag
  2. Split the stack (ctrl+shift+left drag)
  3. Place the split items elsewhere in the bag
  4. Attempt to remove the split items from the bag - they cannot be removed
  5. Move the original stack outside of the bag
  6. Close the bag
  7. Reopen the bag - the split items are missing and have not been added to the original stack.

Expected behavior
Stacks cannot be split inside of a bag.

Screenshots
image

@TheTinkeringIdiot TheTinkeringIdiot added bug Something isn't working needs-verification This is a new issue or affects a recently changed system and requires a tester to confirm the issue labels Jan 29, 2024
@3F1-1009
Copy link

Confirmed using steps above. Additionally, the original stack that you got back from bag can no longer be stacked with other instances of same item.

@3F1-1009 3F1-1009 removed the needs-verification This is a new issue or affects a recently changed system and requires a tester to confirm the issue label Jan 30, 2024
@portalerprk portalerprk reopened this Feb 12, 2024
@TheTinkeringIdiot
Copy link
Collaborator Author

Issue remains but has changed slightly with recent fixes.

The bag-split stack of items can again be re-stacked with items outside of the bag, so the aspect reported by 3F1 appears to be resolved.

Stacks of items can still be split inside of bags. Doing so and closing the bag will result in the split-off portion being lost. Splitting a stack and attempting to re-combine them while both are still in the bag can cause varying behavior. Attempting to add the split-off stack back to the original will cause the split-off stack to be lost when the bag is closed. Attempting to add the original stack to the split-off stack will cause both stacks to be lose when the bag is closed.

Attempts to replicate this bug on the live servers are met with a "You can't split this item" chat message when attempting to place a split-off stack of items in the same bag as the original stack, and nothing happening when trying to place the split stack elsewhere - the stack simply doesn't split.

image

@portalerprk
Copy link
Contributor

portalerprk commented Feb 13, 2024

On Live
https://github.com/project-rubika/issues/assets/60405799/ed646ff7-b670-47ab-9f25-112418bec8f5

On PRK
https://github.com/project-rubika/issues/assets/60405799/71ef2f2c-a1c2-4952-9c09-c423898e6224

On live I was able to split a stack inside a bag just fine, no message. On PRK I was able to as well (after my changes).

@TheTinkeringIdiot
Copy link
Collaborator Author

Are we on the same version of PRK? Your second gif does not match what I'm seeing in game at all. I can follow your exact steps in that gif and upon logging back in the split items are missing from the bag.

On live it's as your gif shows, but only with consumables. Other stackable items like ammo cannot be split in a bag.

@TheTinkeringIdiot
Copy link
Collaborator Author

Confirmed fixed on latest. Non-consumable stacked items are allowed to split in a bag, which is not allowed on the live game, but that's probably more enhancement than bug. Consumable items split as they do on live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants