Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: also clone program data account whenever a bpf3 program is given in [test.validator.clone] in Anchor.toml file #1481

Closed
paul-schaaf opened this issue Feb 20, 2022 · 4 comments · Fixed by #1495
Labels
cli good first issue Good for newcomers help wanted Extra attention is needed

Comments

@paul-schaaf
Copy link
Contributor

No description provided.

@paul-schaaf paul-schaaf added good first issue Good for newcomers cli labels Feb 20, 2022
@paul-schaaf paul-schaaf changed the title cli: also clone program data account whenever a bpf3 program is given in [test.validator.clone] cli: also clone program data account whenever a bpf3 program is given in [test.validator.clone] in Anchor.toml file Feb 20, 2022
@armaniferrante armaniferrante added the help wanted Extra attention is needed label Feb 20, 2022
@skrrb
Copy link
Contributor

skrrb commented Feb 21, 2022

should the solana rpc endpoint of the validator be a mandatory field? If not, which one should be used to get the account data to check if it's a program?

https://github.com/project-serum/anchor/blob/a604f8595c875a23b8e13c8569577d6a6b1c79bd/cli/src/config.rs#L565

@tomlinton
Copy link
Contributor

Yes it's mandatory. The validator will fail to start if a clone is address is passed without the URL. It'd be nice if Anchor caught that without needing to open the validator log to see it.

@paul-schaaf
Copy link
Contributor Author

@tomlinton is [test.validator.url] the cluster that the test validator is deployed to or is that the cluster the accounts are cloned from?

@tomlinton
Copy link
Contributor

The URL that the accounts are cloned from. It's directly passed to solana-test-validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants