Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow checks #1882

Open
cavemanloverboy opened this issue May 9, 2022 · 3 comments
Open

Overflow checks #1882

cavemanloverboy opened this issue May 9, 2022 · 3 comments

Comments

@cavemanloverboy
Copy link
Contributor

cavemanloverboy commented May 9, 2022 •
edited

As @thesoftwarejedi pointed out, presently the overflow-checks = true does nothing. It must be at the root Cargo.toml. I will submit a PR this AM with the fix and more details about tests for this feature.
@cavemanloverboy
Copy link
Contributor Author

cavemanloverboy commented May 9, 2022 •
edited

I see it's already been caught by 509ef94. I wonder if we should keep the profile parameters in the program directory's Cargo.toml in case anyone ever rips out a program from a workspace and tries to build it themselves for whatever reason.

@cavemanloverboy
Copy link
Contributor Author

@paul-schaaf pinging since you are the author of the aforementioned commit. Any thoughts on keeping the profile at both levels?

@armaniferrante
Copy link
Member

@cavemanloverboy unless there's a downside (I can't think of one), let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@armaniferrante @cavemanloverboy and others