Chore: Use reusable workflows for GitHub actions #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stegaBOB is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
|
Looks good
I'm still unclear in general on the conditions for caching / recaching, plus whatever is going on with setting up new runners / reusing existing compiled files but we can try to maybe roughly document that / optimise it in another PR. Should be good to merge! Don't think it needs a changelog unless you want the props. |
dovahcrow
pushed a commit
to dovahcrow/anchor
that referenced
this pull request
Jan 13, 2023
* reusable workflows * fix name * fix syntax * fix syntax again * update install solana * rename stuff * fix naming * Update test names once more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests and no-caching-tests workflows are nearly identical. The only difference currently is one caches dependencies, while the other doesn't. The rest is just duplicated code. This makes it harder to add new tests or modify existing ones as you need to change both files. This has caused issues in the past. This PR uses reusable workflows to call to the
tests-reusableworkflow and conditionally cache stuff based on inputs from the existing workflows.I also updated the
install-solanaaction to be a bit more efficient.